I have used the metal thai cups with the thong like straps and regular jock straps and don't like either of them. I use the compression shorts cup by Shock Dr. They are much more comfy then the other two styles. The metal Thai cup is stronger but I'll take the SD over it.
I carry all three styles and I sell way more SD then the other two.
www.SSFgear.com